Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Boolean type for --firewall #3041

Merged
merged 2 commits into from Feb 24, 2021
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yet to add some.

Motivation / Use-Case

Allow webpack serve --firewall and webpack serve --no-firewall.

Breaking Changes

None

Additional Info

I will add some tests if this feature is accepted.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #3041 (477f993) into master (b16e82a) will increase coverage by 1.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
+ Coverage   90.64%   92.30%   +1.66%     
==========================================
  Files          37       37              
  Lines        1261     1261              
  Branches      327      327              
==========================================
+ Hits         1143     1164      +21     
+ Misses        110       92      -18     
+ Partials        8        5       -3     
Impacted Files Coverage Δ
lib/utils/routes.js 98.21% <0.00%> (+3.57%) ⬆️
lib/utils/DevServerPlugin.js 100.00% <0.00%> (+26.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16e82a...477f993. Read the comment docs.

@alexander-akait alexander-akait merged commit 6711c1d into master Feb 24, 2021
@alexander-akait alexander-akait deleted the feat/no-firewall branch February 24, 2021 12:00
@alexander-akait
Copy link
Member

Thanks

@snitin315
Copy link
Member Author

Should we allow a negative flag for each boolean? like we do for core flags.

@alexander-akait
Copy link
Member

I think yes, but only where it makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants