refactor: client

[alexander-akait]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Existing

Motivation / Use-Case

Improve structure, refactor code, allow to run on IE11/IE10/IE9, IE8 is not supported, sorry

Breaking Changes

No

Additional Info

IE11/IE10:

module.exports = {
  entry: {
    entry: [
      'whatwg-fetch', 
      'core-js/features/promise', 
      './entry.js'
    ],
  },
};

IE9:

module.exports = {
  entry: {
    entry: [
      'whatwg-fetch', 
      'core-js/features/promise', 
      './entry.js'
    ],
  },
  devServer: {
    transportMode: 'sockjs',
  },
};
``

[alexander-akait]

I will improve eslint configuration tomorrow

[alexander-akait]

Also we need improve modules/logger (i.e. built-in webpack logger), inside code we have Symbol, maybe we need to migrate on https://github.com/webpack/webpack/blob/master/hot/log.js or do not polling Symbol to global scope, I need time to think about it

[codecov]

Codecov Report

Merging #3129 (015bf88) into master (b123f31) will increase coverage by 2.82%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3129      +/-   ##
==========================================
+ Coverage   91.95%   94.78%   +2.82%     
==========================================
  Files          37       37              
  Lines        1292     1207      -85     
  Branches      349      325      -24     
==========================================
- Hits         1188     1144      -44     
+ Misses         96       57      -39     
+ Partials        8        6       -2     

Impacted Files	Coverage Δ
client-src/modules/sockjs-client/index.js	100.00% <ø> (ø)
client-src/modules/strip-ansi/index.js	100.00% <ø> (ø)
client-src/overlay.js	97.01% <ø> (ø)
client-src/utils/createSocketUrl.js	100.00% <ø> (ø)
client-src/utils/getCurrentScriptSource.js	100.00% <ø> (ø)
client-src/utils/reloadApp.js	86.95% <ø> (ø)
client-src/utils/sendMessage.js	85.71% <ø> (ø)
lib/servers/SockJSServer.js	94.11% <ø> (ø)
lib/utils/DevServerPlugin.js	97.26% <ø> (ø)
lib/utils/getSocketClientPath.js	100.00% <ø> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b123f31...015bf88. Read the comment docs.

[alexander-akait]

Weird with coverage 😕

[alexander-akait]

I want postpone logger refactor for #2932

[alexander-akait]

macos on github actions is hell...