feat: bonjour options #3202
Merged
feat: bonjour options #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
=======================================
Coverage 95.19% 95.20%
=======================================
Files 38 38
Lines 1249 1251 +2
Branches 350 351 +1
=======================================
+ Hits 1189 1191 +2
Misses 54 54
Partials 6 6
Continue to review full report at Codecov.
|
anshumanv
requested review from
alexander-akait,
hiroppy,
knagaitsev and
snitin315
as code owners
|
@alexander-akait tests for object bonjour config and use |
snitin315
reviewed
Apr 20, 2021
alexander-akait
approved these changes
Apr 20, 2021
snitin315
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
wip
Motivation / Use-Case
Allows options from bonjour for more configuration - https://github.com/watson/bonjour#initializing
Breaking Changes
no
Additional Info