Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect logLevel and logProvider option for proxy #3257

Merged
merged 3 commits into from May 6, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

fixes #3234

Motivation / Use-Case

respect logLevel and logProvider option for proxy

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #3257 (b299362) into master (c2805fe) will increase coverage by 1.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
+ Coverage   93.76%   95.38%   +1.62%     
==========================================
  Files          34       34              
  Lines        1234     1236       +2     
  Branches      350      352       +2     
==========================================
+ Hits         1157     1179      +22     
+ Misses         68       51      -17     
+ Partials        9        6       -3     
Impacted Files Coverage Δ
lib/Server.js 95.38% <100.00%> (+0.22%) ⬆️
lib/utils/DevServerPlugin.js 98.75% <0.00%> (+23.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2805fe...b299362. Read the comment docs.

snitin315
snitin315 previously approved these changes May 6, 2021
anshumanv
anshumanv previously approved these changes May 6, 2021
@alexander-akait alexander-akait merged commit 199baec into master May 6, 2021
@alexander-akait alexander-akait deleted the issue-3234 branch May 6, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0-beta.2 proxy logLevel silent does not work
3 participants