Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async API #3608

Merged
merged 20 commits into from Aug 12, 2021
Merged

feat: async API #3608

merged 20 commits into from Aug 12, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP

Motivation / Use-Case

new async API + new callback API for compatibility purposes

Breaking Changes

No

Additional Info

listen and close depreacted

@alexander-akait
Copy link
Member Author

@snitin315 after this PR we should rewrite out tests on new API (async API) and remove test/helpers/test-server.js in favor const server = new Server(); await server.start(); /* Test logic */ server.close(). Should be easy task

@snitin315
Copy link
Member

I will update 👍🏻

@alexander-akait
Copy link
Member Author

Now our tests is smaller due async API

@alexander-akait
Copy link
Member Author

The next step - migration webpack-cli on the new async API, WIP

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #3608 (5057067) into master (1307332) will decrease coverage by 0.40%.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3608      +/-   ##
==========================================
- Coverage   94.27%   93.86%   -0.41%     
==========================================
  Files          15       15              
  Lines        1274     1287      +13     
  Branches      440      442       +2     
==========================================
+ Hits         1201     1208       +7     
- Misses         67       72       +5     
- Partials        6        7       +1     
Impacted Files Coverage Δ
lib/Server.js 93.83% <89.18%> (-0.50%) ⬇️
lib/utils/DevServerPlugin.js 99.27% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1307332...5057067. Read the comment docs.

@alexander-akait alexander-akait merged commit 974ce25 into master Aug 12, 2021
@alexander-akait alexander-akait deleted the feat-new-async-api-again branch August 12, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants