-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async API #3608
feat: async API #3608
Conversation
@snitin315 after this PR we should rewrite out tests on new API (async API) and remove |
I will update 👍🏻 |
Now our tests is smaller due async API |
The next step - migration webpack-cli on the new async API, WIP |
Codecov Report
@@ Coverage Diff @@
## master #3608 +/- ##
==========================================
- Coverage 94.27% 93.86% -0.41%
==========================================
Files 15 15
Lines 1274 1287 +13
Branches 440 442 +2
==========================================
+ Hits 1201 1208 +7
- Misses 67 72 +5
- Partials 6 7 +1
Continue to review full report at Codecov.
|
For Bugs and Features; did you add new tests?
WIP
Motivation / Use-Case
new async API + new callback API for compatibility purposes
Breaking Changes
No
Additional Info
listen
andclose
depreacted