Skip to content

Add documentation for Rule.use as a function #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 31, 2018
Merged

Add documentation for Rule.use as a function #2694

merged 6 commits into from
Dec 31, 2018

Conversation

bew
Copy link
Contributor

@bew bew commented Dec 5, 2018 •
edited
Loading

Adds some documentation for using a function for Rule.use configuration.

For the object passed to the function, I'm not surewhat realResource, compiler & resourceQuery are for, and I'd appreciate some help to explain them succinctly , thank you

Fixes #2691

@glenjamin glenjamin mentioned this pull request Dec 6, 2018
Merged
EugeneHlushko
EugeneHlushko requested changes Dec 8, 2018
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

@montogeek
Copy link
Member

@bew Friendly ping

EugeneHlushko and others added 2 commits December 18, 2018 18:46
@EugeneHlushko @bew
Apply suggestions from code review
105f7c7 
Co-Authored-By: bew <bew@users.noreply.github.com>
@bew
Update type & compiler description
dd0f7fa
@bew
Copy link
Contributor Author

bew commented Dec 19, 2018

I'm still not sure what resourceQuery is, it's never populated in the webpack config we use, anyone can help? Thank you

@EugeneHlushko
Copy link
Member

The build fails, markdown lint doesnt pass with error:

./src/content/configuration/module.md: 324: MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- `resource`: The path to the ..."]

@EugeneHlushko
Copy link
Member

ResourceQuery needs a look, dont have time today. If you dont have time either i would suggest a change

EugeneHlushko
EugeneHlushko reviewed Dec 19, 2018
View reviewed changes
EugeneHlushko
EugeneHlushko reviewed Dec 24, 2018
View reviewed changes
@EugeneHlushko EugeneHlushko merged commit cb25c9b into webpack:master Dec 31, 2018
@EugeneHlushko
Copy link
Member

Thanks!

@bew bew deleted the patch-1 branch December 31, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra left review comments

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

+1 more reviewer

@dhruvdutt dhruvdutt dhruvdutt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bew @montogeek @EugeneHlushko @sokra @dhruvdutt