docs: added more info for magic comments #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: added title of Magic Comments so it can be found in the search bar. Added preload and prefetch as although they are in the guide I feel it would be beneficial to have all the magic comments in the one place and a link to the guide for more. Any suggestions just let me know
montogeek
requested changes
Dec 10, 2018
EugeneHlushko
requested changes
Dec 10, 2018
minor corrections from reviews. Let me know what you think.
|
@EugeneHlushko @montogeek let me know if those changes are ok |
montogeek
approved these changes
Dec 16, 2018
|
@EugeneHlushko Please check again |
EugeneHlushko
requested changes
Dec 17, 2018
Co-Authored-By: debs-obrien <debs-obrien@users.noreply.github.com>
Co-Authored-By: debs-obrien <debs-obrien@users.noreply.github.com>
Co-Authored-By: debs-obrien <debs-obrien@users.noreply.github.com>
EugeneHlushko
approved these changes
Dec 17, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: added title of Magic Comments so it can be found in the search bar. Added preload and prefetch as although they are in the guide I feel it would be beneficial to have all the magic comments in the one place and a link to the guide for more. Any suggestions just let me know