Skip to content

feat(manifest) reduce maintenance amount of PWA files by using a plug… #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2019

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Jun 12, 2019

  • reduce maintenance amount of PWA files by using a plugin to cut icons and generate manifest.json
  • fix majority of potential issues with adding to home screens across devices

Also renders #3103 's approach redundant

…in; fix majority of potential issues with adding to homescreens across devices
@netlify
Copy link

netlify bot commented Jun 12, 2019

Preview is ready

Built with commit 5413a0a

https://deploy-preview-3115--webpackjsorg-netlify.netlify.com

@netlify
Copy link

netlify bot commented Jun 12, 2019

Preview is ready

Built with commit 3c9fdab

https://deploy-preview-3115--webpackjsorg-netlify.netlify.com

@montogeek montogeek merged commit 23ad975 into master Jul 9, 2019
@montogeek
Copy link
Member

Thanks!

@montogeek montogeek deleted the optimize/manifest branch July 9, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants