-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Swipable navigation menu on mobile #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tested this out, looks good thank you! I would just ask that you continue to follow BEM for the new elements you added and sign the CLA. Once that's done this should be good to go. |
@skipjack the opener element right? |
@prateekbh it would be both. Basically, with BEM and react, each component is a "block" (in this case |
Hey @prateekbh, hope you don't mind I pushed the fixes to your fork. Would you mind signing the CLA? Once that's done that I can merge 👍 |
Hey @skipjack, done :) |
Also please let me know when will it be deployed? |
Closing and re-opening with some last fixes and resolving of merge conflicts. @prateekbh thank you, I'll be merging the updated PR momentarily. I don't do the deployments, but I suspect you'll see a PR called "Deploy" or "Publish" pop up this week -- once that's merged you should see the live site updated with these changes and others. |
This adds the capability for the navigation menu to open and close by swiping in either direction.
This also takes care that a diagonal swipe should result in only one of the two things
wither horizontal navigation close/open or vertical scroll.