Skip to content

docs(devServer): add type array for contentBasePublicPath option #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2020
Merged

docs(devServer): add type array for contentBasePublicPath option #3674

merged 4 commits into from
Apr 4, 2020

Conversation

snitin315
Copy link
Member

Fixes #3668

added type array for contentBasePublicPath option.

EugeneHlushko
EugeneHlushko requested changes Apr 3, 2020
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the phrasing can be clearer, left a suggestion. Besides now you could also mention this in contentBase itself where it says: It is also possible to serve from multiple directories:

snitin315 and others added 2 commits April 3, 2020 20:59
@snitin315 @EugeneHlushko
improve description
4501ea3 
Co-Authored-By: Eugene Hlushko <jhlushko@gmail.com>
@snitin315
update devServer.contentbase
19dda01
@EugeneHlushko EugeneHlushko merged commit 30c96f8 into webpack:master Apr 4, 2020
@EugeneHlushko
Copy link
Member

Thanks!

@snitin315 snitin315 deleted the devserver branch April 5, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek montogeek approved these changes

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(devServer): add type array reference in contentBasePublicPath
3 participants
@snitin315 @EugeneHlushko @montogeek