Skip to content

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Nov 21, 2016

screen shot 2016-11-21 at 2 27 41 pm

Adds a version to the non-mobile sidebar. We should have a mobile version as well for the next milestone.

Fixes #327, fixes #354

@TheLarkInn
Copy link
Member Author

Fixes #327 - Part 3

@TheLarkInn
Copy link
Member Author

@sokra @bebraw I was able to fix the sidebar link not existing for index pages. Currently they will highlight malibu if they are active pages and clicking on the headers themselves will take you to this pages;

Copy link
Member

@SpaceK33z SpaceK33z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both fixes - they work great.

@TheLarkInn TheLarkInn merged commit 1d03ea8 into develop Nov 22, 2016
@SpaceK33z SpaceK33z deleted the feature/add_version_to_sidebar branch November 22, 2016 18:14
TheLarkInn pushed a commit that referenced this pull request Nov 22, 2016
* Improve resolve docs

* Fix typo

* Add table text

I just want to trigger a rebuild so the CLAbot works

* More consistency

But really CLAbot is buggy today...

* Fixed small typo in get started guide

* Fixes some typos in Get Started with Webpack

Adds a missing comma in webpack.config.js code example and a word in 'Using webpack with npm' section.

* Minor text fixes

* Use double quotes in html for consistency

* Feature/add version to sidebar (#395)

* feat(sidebar): add version in desktop sidebar

* feat(sidebar): update bottom margin

* Update sidebar.jsx

remove unused var

* fix(sidebar): fix index pages missing from section and fix layout

* Improve HMR docs (#389)

* Improve HMR docs

* Fix link

* Add concept page for HMR

* Small improvements

Really I just want to trigger a rebuild because the clabot is not working.

* More devtool docs (#375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants