Skip to content

Conversation

thesurenk
Copy link

Referring to this webpack/webpack-dev-server#2759

Updated the below documentation to use webpack serve instead of webpack-dev-server in package.json files.

  1. "Development" (/src/content/guides/development.md)
  2. "Production" (/src/content/guides/production.md)

@jsf-clabot
Copy link

jsf-clabot commented Oct 15, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@vercel
Copy link

vercel bot commented Oct 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/a226azmwb
✅ Preview: https://webpack-js-org-git-update-guides-to-webpack-serve.webpack-docs.vercel.app

@thesurenk
Copy link
Author

thesurenk commented Oct 15, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ksurendra
❌ Suren Konathala

Suren Konathala seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Signed the CLA before submitting the PR at https://cla.js.foundation/webpack/webpack.js.org?pullRequest=4069

@alexander-akait
Copy link
Member

@ksurendra you use different emails in commit and in CLA

thesurenk and others added 2 commits October 16, 2020 08:20
… serve' instead of 'webpack-dev-server'"

This reverts commit 3c69e8c.
@thesurenk
Copy link
Author

@ksurendra you use different emails in commit and in CLA

Thanks. I used the same email address while committing, not sure what i missed. I updated the author details and pushed another commit. Does this help? If not, we can close this PR and i can send another PR.

@anshumanv
Copy link
Member

PR diff shows no changes, can you verify?

@thesurenk
Copy link
Author

PR diff shows no changes, can you verify?

Updated only the author name, email.. not the code. Not sure what is happening.

Screen Shot 2020-10-16 at 8 54 16 AM

@chenxsan
Copy link
Member

Closed via #4091, and thanks for your contribution here @ksurendra.

@chenxsan chenxsan closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants