Skip to content

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Dec 14, 2020

closes #4200

Before

After

@vercel
Copy link

vercel bot commented Dec 14, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/d0dxcd6an
✅ Preview: https://webpack-js-org-git-feature-responsive-table.webpack-docs.now.sh

@chenxsan
Copy link
Member Author

ERROR in ./content/plugins/_eslint-webpack-plugin.md
Module build failed (from ../node_modules/remark-loader/dist/cjs.js):
NonErrorEmittedError: (Emitted value instead of an instance of Error) TypeError: Cannot read property 'value' of undefined

@chenxsan chenxsan marked this pull request as ready for review December 17, 2020 00:52
@chenxsan chenxsan merged commit 8fd4c29 into webpack:master Dec 17, 2020
@chenxsan chenxsan deleted the feature/responsive-table branch December 17, 2020 00:56
@montogeek
Copy link
Member

It is also a good practice to give credits to the original author, once again I reiterate that these changes have to be outside of the repo, in external dependencies.

@montogeek montogeek added the UI/UX label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in remark-responsive-tables
2 participants