Fix asset handling #450
Merged
Fix asset handling #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it generates a single CSS file and handles assets through webpack.
|
Yeah. I set it up so that it generates a separate font file instead of inlining. Easy to adjust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it generates a single CSS file and handles assets through webpack. Instead of multiple CSS files, you end up with a single now so the result should be faster as well.
Interactive components cannot build to styling anymore so I moved the reference to places where
Interactiveis used instead. This has to do with the fact that those are evaluated separately from the main build. Maybe I could stub this in the future somehow but for now doing this extra step seemed like the smartest move.Please test locally and let me know how it goes. Note that there's a new dependency (copy plugin) and also antwar received a couple of updates in the process (simpler now).