Added split code blocks to home page #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
changed the title
NejcZdovc
force-pushed
the
feature/#350
branch
2 times, most recently
from
45b72c7 to
881b47f
Compare
|
Looks good to me. Do you want to add anything else to the PR? |
|
Can you rebase against |
NejcZdovc
force-pushed
the
feature/#350
branch
from
881b47f to
22f9e67
Compare
|
@bebraw rebased |
SpaceK33z
reviewed
Jan 1, 2017
| } | ||
|
|
||
| codeArray.forEach(item => { | ||
| // if item is not code, then check for html tags and parse accordingly |
There was a problem hiding this comment.
What happens with code in backticks (e.g. `<script>`)?
There was a problem hiding this comment.
I still need to cover this scenario, when we use only single backtick
There was a problem hiding this comment.
Single backtick is now covered as well.
NejcZdovc
force-pushed
the
feature/#350
branch
from
22f9e67 to
39a5fb0
Compare
|
@SpaceK33z can you look at it again please |
NejcZdovc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #350
Now you can write HTML directly into the markdown files.