Skip to content

Update source-map-dev-tool-plugin.mdx #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

slav-getov
Copy link
Contributor

@slav-getov slav-getov commented Aug 2, 2023

Hello,

I think the word 'next' used here is confusing. If the intent of the author was 'the content directly after this sentence' then using 'the following' would be way better and understandable.

Please advise/review.

Hello,

I think the word 'next' used here is confusing. If the intent of the author was 'the content directly after this sentence' then using 'the following' would be way better and understandable. 

Please advise/review.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 2, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: slav-getov / name: Preslav Getov (606494c)

@vercel
Copy link

vercel bot commented Aug 2, 2023

@slav-getov is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@slav-getov
Copy link
Contributor Author

slav-getov commented Aug 3, 2023

Hey when someone sees/decides this is fine should I authorise first or wait for the review? Thank you!

@chenxsan
Copy link
Member

chenxsan commented Aug 4, 2023

  • Please click here to be authorized

Hi, please sign the CLA here https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18915764/61886109/6986/#/?version=2, the change looks good to me.

@slav-getov
Copy link
Contributor Author

I have signed the easyCLA, do I need verbal account too?

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit acc0b66 into webpack:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants