Skip to content

Upload WACZ via UI #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 21, 2023
Merged

Upload WACZ via UI #992

merged 26 commits into from
Jul 21, 2023

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jul 17, 2023 •
edited
Loading

Resolves #986. Follows #993 API changes

Changes

Users can now upload .WACZ archives from the "Archived Data" page.

Manual testing

  1. Log in and click "Archived Data"
  2. Click "Upload Archive"
  3. Click "Browse Files" and select a file. Verify file name and size is shown
  4. Click trash icon in file details. Verify file is removed
  5. Search for tags and collections. Verify tag and collection input works as expected
  6. Re-select a file, enter a name, and click "Upload File". Verify file upload progress is shown
  7. Click outside of the modal. Verify confirmation is shown
  8. Click "Yes". Verify that upload is canceled via network tab
  9. Repeat steps 2-6. Verify upload shows correct progress values
  10. Wait for upload to complete. Verify clicking link in toast notification takes you to the upload detail page

Screenshots

Page Image/video
Upload Archive dialog - initial state Screen Shot 2023-07-18 at 4 43 27 PM
Upload Archive dialog - File selected and metadata filled Screen Shot 2023-07-18 at 4 43 59 PM
Upload Archive dialog - Uploading Screen Shot 2023-07-19 at 3 44 15 PM
Upload Archive dialog - Cancel confirmation Screen Shot 2023-07-18 at 5 12 00 PM
Archived Data - Success toast notification Screen Shot 2023-07-19 at 2 44 04 PM

Follow-ups

  • Retry
  • Multi-file upload

@ikreymer

This comment was marked as resolved.

Sign in to view
@SuaYoo SuaYoo changed the title Frontend upload single wacz Upload WACZ via UI Jul 19, 2023
@SuaYoo SuaYoo requested review from ikreymer and Shrinks99 July 19, 2023 22:55
@SuaYoo SuaYoo marked this pull request as ready for review July 19, 2023 22:55
@SuaYoo SuaYoo requested a review from tw4l July 19, 2023 22:56
Shrinks99
Shrinks99 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! One small icon change and we're good to go! :D

tw4l
tw4l approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and working well! Appreciate the detailed testing instructions :)

@ikreymer @Shrinks99
Update frontend/src/pages/org/crawls-list.ts
b000c0a 
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
@ikreymer ikreymer merged commit 75b011f into main Jul 21, 2023
@ikreymer ikreymer deleted the frontend-upload-single-wacz branch July 21, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

+1 more reviewer

@Shrinks99 Shrinks99 Shrinks99 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable crawl uploading via UI
4 participants
@SuaYoo @ikreymer @Shrinks99 @tw4l