Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the new
logoHomeUrl
option to be the last arg to theVueui.main()
constructor so that any locally modified templates won't break when updating to pywb 2.7.3.It also adds
yarn install
to the Vue build script for convenience.Motivation and Context
Without this change, the change the Vue app constructor in 2.7.3 could result in arg mismatches in locally modified
frame_insert.html
andquery.html
templates.Types of changes
Checklist: