Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue main order #809

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Vue main order #809

merged 2 commits into from
Feb 2, 2023

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Feb 2, 2023

Description

This PR moves the new logoHomeUrl option to be the last arg to the Vueui.main() constructor so that any locally modified templates won't break when updating to pywb 2.7.3.

It also adds yarn install to the Vue build script for convenience.

Motivation and Context

Without this change, the change the Vue app constructor in 2.7.3 could result in arg mismatches in locally modified frame_insert.html and query.html templates.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

This ensures that any locally modified templates won't break when
upgrading to pywb 2.7.3.
@tw4l tw4l requested a review from ikreymer February 2, 2023 21:14
@tw4l tw4l merged commit c8e78fd into main Feb 2, 2023
@tw4l tw4l deleted the vue-main-order branch February 2, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

2 participants