Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to print the replay frame #814

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

krakan
Copy link
Contributor

@krakan krakan commented Feb 14, 2023

Description

Add a button to print the content of the replay iframe to the list of buttons in the page banner.

Motivation and Context

Printing the content of an iframe is not straight forward in any browser although some are better than others. This change makes it trivial to print the archived pages.
This is particularly important in our case as printing and viewing are the only allowed processes for an archived page.

Screenshots (if appropriate):

The print button with mouse over effect:
2023-02-14-174924_1372x1436_scrot

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l self-requested a review February 15, 2023 18:02
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and layout still looks good at all screen sizes/breakpoints - thanks @krakan ! I'm going to add an option to config.yaml to disable printing in certain context where it might not be encouraged (e.g. reading rooms), but will keep it enabled by default.

@tw4l tw4l merged commit 98be48d into webrecorder:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants