Handle WARC filename conflicts with wb-manager add #902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of not copying a WARC to the archive directory in case of a filename conflict, this PR instead modifies it to add the WARC with
{original_name}-{dupe index}{extension}
- i.e.example.warc.gz
would be renamed toexample-1.warc.gz
, thenexample-2.warc.gz
, and so on, until a filename that doesn't exist in the archive directory is found.Motivation and Context
Should make for a more user-friendly experience of adding archives via
wb-manager add
.Screenshots (if appropriate):
Types of changes
Checklist: