This repository was archived by the owner on May 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "icecandidiate" event listener should be attached
before calling "RTCPeerConnection.setLocalDescription()".
The "icecandidate" event occur as a result of calling
await peerConnection.setLocalDescription(offer);
.(reference: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/icecandidate_event)
So it should be attached earlier.
In the original solution, since the "icecandidate" event handler is attached too late, the callee can not receive the caller ice candidates. (We can check it on log on console since
Got new remote ICE candidate:
does not appear on callee's console log.) In spite of this error, the original solution somehow works when it is tested on LAN. But it does not work on WAN.I checked that it works on WAN after fixing this error.