Moar promises

[fippo]

Lets dogfood on that promises stuff...

I found a really odd bug... createAnswers gets a third constraints argument which doesn't make sense.
@alvestrand is that worth bailing out on in adapter?

[jiayliu]

The answer constraints should not be removed, webrtc looks for it to decide if it receives media or uses bundle:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/source/talk/app/webrtc/mediastreamsignaling.cc&rcl=1437050479&l=442

[fippo]

hrm... that should hopefully work with https://github.com/webrtc/adapter/blob/master/adapter.js#L228-229
now if firefox doesn't error i can fix that.

[fippo]

Firefox throws an error unfortunately :-(

[fippo]

@jiayliu worked around the issue -- ugly but shrug

I've also seen getStats failures since apprtc is using the legacy syntax without a browser switch but that's a different story (and also happens in the currently deployed version when opening the infobox)

[jiayliu]

Does it mean we have a regression in infobox on firefox?

[fippo]

I doubt it's a regression. Firefox getStats has never worked without a track selector as its called in https://github.com/webrtc/apprtc/blob/master/src/web_app/js/peerconnectionclient.js#L172

[jiayliu]

lgtm.
ok to merge?

[fippo]

yeah. The Firefox issue should soon be fixed but I guess it will take time to go to the stable channel there.