This repository was archived by the owner on May 13, 2024. It is now read-only.
Add grunt, package info etc #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis will run after this PR. |
|
that allows us to just require('whatever-we-call-this-on-npm/src/selenium/selenium-lib') right? Any way way can get rid of the path? Maybe by having an index.js that requires src/selenium/selenium lib and exports this as module.exports.selenium? LGTM otherwise |
|
Re for the require question: Yes. Yeah the path is a bit long but I foresee adding more stuff in here, having a main.js file which can control what's being exposed etc is a good idea. Will add that. |
KaptenJansson
added a commit
that referenced
this pull request
Jan 28, 2016
Add grunt, package info etc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fippo PTAL