Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Conversation

KaptenJansson
Copy link
Contributor

@fippo PTAL

test/test.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you omit the () intentionally? Didn't even know that was possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that was a mistake when cleaning up :( (That's why it's bad writing code in a string ;))

@fippo
Copy link
Contributor

fippo commented Feb 1, 2016

needs skip-test for Firefox. LGTM otherwise.
Can you also turn off travis' build on push?

@KaptenJansson
Copy link
Contributor Author

Turned off build on push, addressed comments (oddly enough throw 'skip test' did not work). Also replaced jshint env comments with eslint env. And updated .gitignore + added copyright. Last but not least, I also check that the remoteDescription property is an object on the peerConnection to make sure it's a peerconnection object rather than just any object.

@fippo
Copy link
Contributor

fippo commented Feb 2, 2016

👍

KaptenJansson added a commit that referenced this pull request Feb 3, 2016
@KaptenJansson KaptenJansson merged commit bbf0028 into master Feb 3, 2016
@KaptenJansson KaptenJansson deleted the addGetStatsTest branch February 3, 2016 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants