Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer navigator.userAgentData for browser detection #1146

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

fippo
Copy link
Member

@fippo fippo commented Mar 7, 2024

fixes #764,#1017

(previously known as #1103 but needed a new PR due to the switch from master to main)

@fippo fippo force-pushed the useragentdata branch 2 times, most recently from 6483d6f to 2989d73 Compare March 8, 2024 07:55
@fippo
Copy link
Member Author

fippo commented Mar 8, 2024

@yoavweiss and @miketaylr does that look forward-compatible?

(I'll yell at the tests separately...)

src/js/utils.js Show resolved Hide resolved
@fippo fippo merged commit 3d2ea98 into main Mar 24, 2024
5 checks passed
@fippo fippo deleted the useragentdata branch March 24, 2024 19:30
@fippo fippo added the breaking change breaking change that requires a major version bump label Mar 24, 2024
@fippo fippo mentioned this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change breaking change that requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome will be identified as Safari if webkitGetUserMedia is removed
2 participants