Skip to content

Replace request with got #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 20, 2021
Merged

Replace request with got #445

merged 7 commits into from
Jun 20, 2021

Conversation

s0ph1e
Copy link
Member

@s0ph1e s0ph1e commented May 8, 2021 •
edited
Loading

Replace deprecated request module with got, resolves #401

Breaking changes:

  • Need to use another format for request options

Useful links (to add in docs):

To do:

  • Update readme
  • Update migration doc
  • Update release notes
  • Test with puppeteer, phantom plugins

@s0ph1e s0ph1e marked this pull request as ready for review May 8, 2021 20:18
@s0ph1e s0ph1e merged commit 44cc74c into master Jun 20, 2021
@s0ph1e s0ph1e deleted the replace-request branch June 20, 2021 16:45
This was referenced Dec 24, 2021
Closed
Closed
@s0ph1e s0ph1e mentioned this pull request Oct 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request is deprecated
1 participant
@s0ph1e