Fix long-polling backup support #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR as well @elthariel. We have actually decided to deprecate the long polling backup in favor of third party shims such as Flash Sockets. I mainly added it to support Heroku but they are now adding native WebSocket support so that use case is no longer in effect. If you fix the tests I will merge it for now until I have time to officially remove support for it. Removing the support for the HTTP adapter is going to clean up the implementation of the Connection class on the server and the JavaScript client significantly. The existing long polling never worked correctly in old versions of Internet Explorer anyways which was the only other real use case that I am aware of. |
|
Thanks for fixing the spec. Merging now. |
DanKnox
added a commit
that referenced
this pull request
Oct 27, 2013
Fix long-polling backup support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the issue described in #89.