-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to electron 4 #1590
Update to electron 4 #1590
Conversation
Reviewing items from the Electron Breaking Changes doc: https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#breaking-api-changes-20 Breaking API Changes (2.0)
|
Reviewing items from the Electron Breaking Changes doc: https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#breaking-api-changes-30 Breaking API Changes (3.0)
|
Fix hiddenInset (Mac) titlebar style for electron 4
Thanks a lot for your review @dsernst, very useful. Note that I may have broken something by dropping the depreciated I guess the idea was, if the application is already running and called a second time, the argument, presumably a torrent file, would be passed and added to the instance running. |
Reviewing items from the Electron Breaking Changes doc: https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#planned-breaking-api-changes-40 Breaking API Changes (4.0)
|
Ah. Yes, can confirm that I'm having trouble adding a torrent via magnet link when the app is already open. |
I'm trying to test my own fix for this... but even on So the issue reported above might not have been introduced by your code changes. Unsure how to proceed. |
You may want to take a look at my Electron 3 PR which was not merged #1481. |
Electron 4: Migrate .openDevTools() for new 'detach' pattern
With the remaining fix @mathiasvr put in, it looks good to me. |
@@ -55,7 +55,7 @@ | |||
"buble": "^0.19.6", | |||
"cross-zip": "^2.0.1", | |||
"depcheck": "^0.7.2", | |||
"electron": "^1.8.8", | |||
"electron": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
src/main/index.js
Outdated
app.quit() | ||
} else { | ||
app.on('second-instance', (event, commandLine) => onAppOpen(commandLine)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this logic repeated below? It seems like this will cause the 'second-instance'
event to be registered twice. Is this intentional?
Also, can you resolve |
# Conflicts: # package-lock.json # package.json
@feross, can you please update the review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, I didn't test it though.
Thanks for landing this, @Borewit! |
Beautiful :´) |
Related to PR: #1549.
I have not tested these changes thoroughly.