build: add package Github Action #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
approved these changes
Nov 9, 2020
|
I believe the cache could be done after npm install, so it's just running the package command |
|
hey @hicom150 — this is super cool. I'd love to help review but can you help me understand how to best do that to ensure this is working correctly? I'm not as familiar with Github Actions (yet). Is it possible to test these builds before merging? |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
@github-actions Yes, still relevant. This would be very cool & could significantly unblock / speed up development. |
DiegoRBaquero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add package Github Action. With this action that can be manually triggered via
Actionsmenu, Linux, MacOS and Windows build will be launched andlinux.zip,macos.zipandwindows.zipartifacts will be generated.It is important to note that MacOS and Windows installers are currently not signed, so we will have to add this in next steps 😅. I see this PR as the first step towards package build automation 😉
Which issue (if any) does this pull request address?
#1849
Is there anything you'd like reviewers to focus on?