-
Notifications
You must be signed in to change notification settings - Fork 155
finish MockPuppet #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…renxiaoya # Conflicts: # wechaty/src/test/kotlin/io/github/wechaty/user/RoomTest.kt
diaozxin007
reviewed
Jun 10, 2020
fun resolveInstance(wechatyOptions: WechatyOptions): Future<Puppet> { | ||
log.info("PuppetManager resolveInstance(${JsonUtils.write(wechatyOptions)})") | ||
|
||
return if ("wechaty-puppet-hostie" == wechatyOptions.puppet) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尝试使用反射技术来加载,如果有第三个 puppet 还需要修改代码。
diaozxin007
requested changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尝试使用反射,或者 kotlin 的委托 https://www.kotlincn.net/docs/reference/delegation.html 来解决 puppet 的加载问题
…lementations from wechaty pom,just only dependents puppet
diaozxin007
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContractGender
toContactGender
.old:
now: