Skip to content

Conversation

jiaqianjing
Copy link
Contributor

@jiaqianjing jiaqianjing commented Aug 20, 2021

  1. 加入了一些中文翻译
  2. 使用 python code 替换了 js code
  3. 修正了一些在 python 中的方法名。

@jiaqianjing jiaqianjing requested a review from a team as a code owner August 20, 2021 01:27
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

@jiaqianjing jiaqianjing changed the title Improve Docs: room module [WIP]Improve Docs: room module Aug 20, 2021
@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 20, 2021

Please sign CLA and make CI green, go ahead to push your great work.

@jiaqianjing
Copy link
Contributor Author

jiaqianjing commented Aug 20, 2021

Please sign CLA and make CI green, go ahead to push your great work.
@wj-Mcat Colud you please give me a valid token, becuase my free token has been expired. So that I can check it that code example is valid.
image

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 22, 2021

Please sign CLA and make CI green, go ahead to push your great work.

@wj-Mcat Colud you please give me a valid token, becuase my free token has been expired. So that I can check it that code example is valid.

image

You can use web protocol token to develop bot. The token is personal things which is not suitable to be transfered.

If you have been a contributor of python-wechaty, you can get the long-term free token.

@jiaqianjing jiaqianjing changed the title [WIP]Improve Docs: room module Improve Docs: room module Aug 24, 2021
@jiaqianjing
Copy link
Contributor Author

@wj-Mcat PLS Review

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your awesome improvement on docs. I have some comments to be discussed with you.

You have transfer the ts code to python. But you have also some english description to be improved. Eg: description room.add(...). It will be an excellent job if you have them improved later.

Please go ahead to do good job.

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 26, 2021

Thanks for your improvement on room module doc. I find that tehe are still some English description on method. Can you give more on it to build excellent docs?

@jiaqianjing
Copy link
Contributor Author

jiaqianjing commented Aug 26, 2021

Thanks for your improvement on room module doc. I find that tehe are still some English description on method. Can you give more on it to build excellent docs?

If there is no obvious error, you can close it firstly and I will update it later. (in my free time)

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 27, 2021

Thanks for your improvement on room module doc. I find that tehe are still some English description on method. Can you give more on it to build excellent docs?

If there is no obvious error, you can close it firstly and I will update it later. (in my free time)

Thanks for your great improvement on doc of python-wechaty, It looks good to me, and I will improve it later. If you have free time, you can go ahead to make more improvements in other modules.

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 27, 2021

wechaty/PMC#16

@wj-Mcat wj-Mcat merged commit 78f4fc2 into wechaty:master Aug 27, 2021
@huan
Copy link
Member

huan commented Aug 27, 2021

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You'are invited jiaqianjing to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants