Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for multiple entry files #134

Merged
merged 1 commit into from
Feb 21, 2022
Merged

feat: add support for multiple entry files #134

merged 1 commit into from
Feb 21, 2022

Conversation

ToppleTheNun
Copy link

@ToppleTheNun ToppleTheNun commented Feb 18, 2022 •
edited
Loading

closes #55

@aladdin-add
Copy link

Would it be possible to avoid the breaking changes? e.g. normalize the one entry to an array:

name: string | string[]
input: string | object

@ToppleTheNun
Copy link
Author

Would it be possible to avoid the breaking changes? e.g. normalize the one entry to an array:

name: string | string[]
input: string | object

I believe the input change

Would it be possible to avoid the breaking changes? e.g. normalize the one entry to an array:

name: string | string[]
input: string | object

Made the changes no longer breaking.

@ToppleTheNun ToppleTheNun marked this pull request as ready for review February 18, 2022 16:34
@aladdin-add aladdin-add self-requested a review February 19, 2022 18:10
aladdin-add
aladdin-add approved these changes Feb 21, 2022
View reviewed changes
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!! 😍

@aladdin-add aladdin-add merged commit 2651cd6 into weiran-zsd:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only first entry works when more than one is provided
2 participants
@ToppleTheNun @aladdin-add