🎉 Initial Commit: Let's push time to bring this back to life! #15

sidwebworks · 2021-09-03T19:45:20Z

Changed naming, links etc
Updated Banner
Replaced Parcel with Vite as the main dev tool for example playground.

First steps so far.

src/constants.ts

src/createBuildConfigs.ts

.all-contributorsrc

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

test/e2e/fixtures/lint/file-with-prettier-lint-errors.ts

test/utils/shell.ts

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

sidwebworks · 2021-09-04T01:09:45Z

@aladdin-add Ready to merge!!

aladdin-add

thanks for doing this! I've left a few naming suggestions, and seems the docs(readme) were not updated?

.all-contributorsrc

CHANGELOG.md

package.json

src/createEslintConfig.ts

src/createRollupConfig.ts

test/integration/fixtures/README.md

test/integration/tsdx-build-options.test.ts

test/integration/tsdx-build-withBabel.test.ts

test/integration/tsdx-build-withConfig.test.ts

test/e2e/tsdx-lint.test.ts

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

sidwebworks · 2021-09-04T09:36:33Z

@aladdin-add Done with all the changes, Hmm looks like a test failed, NP lemme see

test/e2e/fixtures/build-default/src/syntax/jsx-import/JSX-import-JSX.jsx

…rt-JSX.jsx

aladdin-add · 2021-09-04T12:25:59Z

src/templates/basic.ts

@@ -1,5 +1,7 @@
 import { Template } from './template';

+//TODO: REPLACE  `@weiran.zsd/tsdx` WITH `@dts-build/dts-build`
+


should be dts-cli?

Are we good to merge?

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

sidwebworks · 2021-09-05T17:16:03Z

@aladdin-add Anything else that is left ? or should I merge this?

aladdin-add

seems the PR mainly includes 4 things:

renaming package tsdx => dts
removing webiste
changing parcel to vite
reformatting some files

what do you think split it to several smaller PRs? (good to keep 1 PR for 1 thing)

aladdin-add · 2021-09-05T19:22:58Z

test/e2e/fixtures/lint/file-with-prettier-lint-errors.ts

-export const foo  = (   ) => 
-!! ('bar')
-;
+export const foo


why changing this file?

Ah this caused an test failure during linting, so to fix the tests I changed it back to faulty file.

sidwebworks · 2021-09-05T19:40:18Z

seems the PR mainly includes 4 things:

renaming package tsdx => dts

removing webiste

changing parcel to vite

reformatting some files

what do you think split it to several smaller PRs? (good to keep 1 PR for 1 thing)

Lol Sorry yes I know, I was trying to edit some things using the github web only. Although it committed every one of them.

aladdin-add · 2021-09-15T07:11:12Z

closing as fixed.

🎉 Initial Commit: Let's push

9b4c201

aladdin-add reviewed Sep 3, 2021

View reviewed changes

src/constants.ts Outdated Show resolved Hide resolved

aladdin-add reviewed Sep 3, 2021

View reviewed changes

src/createBuildConfigs.ts Outdated Show resolved Hide resolved

aladdin-add reviewed Sep 3, 2021

View reviewed changes

src/createBuildConfigs.ts Show resolved Hide resolved

aladdin-add reviewed Sep 3, 2021

View reviewed changes

.all-contributorsrc Outdated Show resolved Hide resolved

aladdin-add marked this pull request as draft September 3, 2021 19:51

sidwebworks and others added 3 commits September 4, 2021 01:24

Update src/constants.ts

c1b3e73

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/createBuildConfigs.ts

18bf094

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/createBuildConfigs.ts

a8e4389

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

aladdin-add reviewed Sep 3, 2021

View reviewed changes

test/e2e/fixtures/lint/file-with-prettier-lint-errors.ts Outdated Show resolved Hide resolved

aladdin-add reviewed Sep 3, 2021

View reviewed changes

test/utils/shell.ts Outdated Show resolved Hide resolved

Update test/utils/shell.ts

6f4fde9

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

sidwebworks marked this pull request as ready for review September 3, 2021 20:13

sidwebworks added the enhancement New feature or request label Sep 3, 2021

sidwebworks marked this pull request as draft September 3, 2021 20:15

sidwebworks marked this pull request as ready for review September 3, 2021 22:13

sidwebworks and others added 3 commits September 4, 2021 03:48

Update package2.json

62a1101

linting errors fixed

b5a3856

🚑 Reviving: Tests fixed

4ec4275

aladdin-add requested changes Sep 4, 2021

View reviewed changes

sidwebworks and others added 9 commits September 4, 2021 14:52

Update package.json

d7998e0

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/createEslintConfig.ts

259ef81

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/createRollupConfig.ts

3aed45f

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/createRollupConfig.ts

8f16528

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/integration/fixtures/README.md

e14007c

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/integration/tsdx-build-options.test.ts

a442791

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/integration/tsdx-build-withBabel.test.ts

d9d0007

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/integration/tsdx-build-withConfig.test.ts

0674bd0

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/e2e/tsdx-lint.test.ts

09b3200

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

sidwebworks and others added 13 commits September 4, 2021 14:58

Update test/e2e/tsdx-build-withTsconfig.test.ts

f556c2d

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/e2e/fixtures/build-default/src/syntax/jsx-import/JSX-B.jsx

9c4ca3a

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/e2e/fixtures/build-default/src/syntax/jsx-import/JSX-A.jsx

d0f45cf

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/e2e/fixtures/build-default/src/syntax/async.ts

233ce49

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update templates/react/tsconfig.json

b2566a1

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update templates/react-with-storybook/tsconfig.json

d5518c0

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update templates/basic/tsconfig.json

585c17f

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/messages.ts

22fc850

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/messages.ts

9f6e66e

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/messages.ts

e1936ec

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update src/messages.ts

b343575

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

⏪ Reverting : Added contributors file

e6e0429

Merge branch 'revamp' of github.com:weiran-zsd/tsdx into revamp

c1829c7

sidwebworks requested a review from aladdin-add September 4, 2021 09:50

🐛 FIX: e2e tests

2be8106

aladdin-add reviewed Sep 4, 2021

View reviewed changes

test/e2e/fixtures/build-default/src/syntax/jsx-import/JSX-import-JSX.jsx Outdated Show resolved Hide resolved

aladdin-add added 2 commits September 4, 2021 20:22

Update test/e2e/fixtures/build-default/src/syntax/jsx-import/JSX-impo…

b21ae24

…rt-JSX.jsx

Update test/e2e/tsdx-build-default.test.ts

d5d7450

aladdin-add reviewed Sep 4, 2021

View reviewed changes

sidwebworks and others added 4 commits September 4, 2021 19:33

Update basic.ts

c886d2f

Update test/e2e/tsdx-build-options.test.ts

e76f43c

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/e2e/tsdx-build-invalid.test.ts

1de7a39

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Update test/e2e/tsdx-lint.test.ts

5ca9c1f

Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

sidwebworks requested a review from aladdin-add September 4, 2021 14:19

aladdin-add reviewed Sep 5, 2021

View reviewed changes

aladdin-add closed this Sep 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Initial Commit: Let's push time to bring this back to life! #15

🎉 Initial Commit: Let's push time to bring this back to life! #15

sidwebworks commented Sep 3, 2021

sidwebworks commented Sep 4, 2021

aladdin-add left a comment •

edited

Loading

sidwebworks commented Sep 4, 2021 •

edited

Loading

aladdin-add Sep 4, 2021

sidwebworks Sep 4, 2021

sidwebworks Sep 4, 2021

sidwebworks commented Sep 5, 2021

aladdin-add left a comment •

edited

Loading

aladdin-add Sep 5, 2021

sidwebworks Sep 5, 2021

sidwebworks commented Sep 5, 2021

aladdin-add commented Sep 15, 2021

		@@ -1,5 +1,7 @@
		import { Template } from './template';

		//TODO: REPLACE `@weiran.zsd/tsdx` WITH `@dts-build/dts-build`

🎉 Initial Commit: Let's push time to bring this back to life! #15

🎉 Initial Commit: Let's push time to bring this back to life! #15

Conversation

sidwebworks commented Sep 3, 2021

sidwebworks commented Sep 4, 2021

aladdin-add left a comment • edited Loading

Choose a reason for hiding this comment

sidwebworks commented Sep 4, 2021 • edited Loading

aladdin-add Sep 4, 2021

Choose a reason for hiding this comment

sidwebworks Sep 4, 2021

Choose a reason for hiding this comment

sidwebworks Sep 4, 2021

Choose a reason for hiding this comment

sidwebworks commented Sep 5, 2021

aladdin-add left a comment • edited Loading

Choose a reason for hiding this comment

aladdin-add Sep 5, 2021

Choose a reason for hiding this comment

sidwebworks Sep 5, 2021

Choose a reason for hiding this comment

sidwebworks commented Sep 5, 2021

aladdin-add commented Sep 15, 2021

aladdin-add left a comment •

edited

Loading

sidwebworks commented Sep 4, 2021 •

edited

Loading

aladdin-add left a comment •

edited

Loading