Cran submission 0.7.6 #33
Conversation
NEWS.md
Outdated
| @@ -1,8 +1,10 @@ | |||
| # eatTools 0.7.6 | |||
|
|
|||
| * add argument checks using the checkmate package | |||
| * bugfix in `halveString()` for splitting at the last instance of a regular expression | |||
| * new function `rbind_fill_vector()` allows `rbind()` for non-dimensional vectors of unequal length, filling empty entries with NA | |||
There was a problem hiding this comment.
NIT: vectors are unidimensional and not non-dimensional? (r didnt i get what you meant?)
There was a problem hiding this comment.
Thanks, I changed it to "unidimensional"
R/makeTria.r
Outdated
There was a problem hiding this comment.
What does this funtion do? According to initial comment and man-page a matrix should be input, but instead a data.frame is taken and returned. Further, I expected according to description that it converts full covariance matrices to triangles but this is just re-sort of columns according to the amount of missings in these columns. This should be described in man-page and further checks should be added that input corresponds to what is needed (dfr and cols with unequal amounts of NAs).
There was a problem hiding this comment.
I've added some checks in the function code and a details section in the description. The function should actually only be called internally and is only exported to the namespace so that eatAnalysis and eatModel packages can access it.
Some final adjustments so that the package can be submitted to CRAN.