Skip to content

Update to comply with the new crates #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Conversation

lipeng31
Copy link
Contributor

@lipeng31 lipeng31 commented Dec 4, 2018

Some APIs have changed since the last commit. This commit updates the source code and Cargo.toml to comply with the changes.

Some APIs have changed since the last commit. This commit updates the
source code and Cargo.toml to comply with the changes.

Signed-off-by: Li Peng <lipeng31@gmail.com>
Signed-off-by: Li Peng <lipeng31@gmail.com>
@weiznich
Copy link
Owner

weiznich commented Dec 4, 2018

Thanks for the PR. This needs to pass the CI at least. As far as I see travis fails because the nightly that is used does not match the updated clippy version. Maybe that should just be switched to cargo clippy and the clippy component from rustup.

@lipeng31
Copy link
Contributor Author

lipeng31 commented Dec 5, 2018

Thanks for the quick reply. I also noticed the CI failure and I'll try to solve this problem. I'm a green hand to rust, and this is the first project I dip in, so it may take me some time.

Copy link
Owner

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks.

@weiznich weiznich merged commit 77fa7aa into weiznich:master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants