Order by not working

[andrejohansson]

Is there anything special i need to do to get ordering to work?

Seen in this picture, I'm trying to order by id. But I've tried different columns with different datatypes (strings, timestamps) but I get the same result. No sorting is done at all.

Thank you for a kick ass crate by the way!

[weiznich]

Can you get the corresponding sql query by enabling the debug feature for wundergraph and register some crate the gives out calls to log::debug!() for example env_logger.

[andrejohansson]

Hmm, seems like no order by gets generated at all:

[2020-03-23T22:12:42Z DEBUG wundergraph::query_builder::selection] Query { sql: "SELECT \"events\".\"id\", \"events\".\"name\", NULL , NULL , NULL , NULL , NULL , \"events\".\"start_time\", NULL , NULL , NULL , NULL FROM \"events\"", binds: [] }

Something wrong with my entity perhaps? Some missing attribute...like "orderable" or something similar?

#[derive(Clone, Debug, Identifiable, Queryable, Associations, WundergraphEntity)]
#[table_name = "events"]
pub struct Event  {
    pub id: i32,

    pub name: String,    
    pub description: Option<String>,

    pub image_url: Option<String>,
    pub location_url:  Option<String>,
    
    pub base_price: Option<i32>,
    pub unit_price: Option<i32>,
    
    pub start_time: chrono::DateTime<Utc>,
    pub end_time: Option<chrono::DateTime<Utc>>,
    
    pub event_type: EventTypeEnum,
    
    pub address_id: Option<i32>,
    #[column_name = "address_id"]
    pub address: HasOne<i32, Address>,

    pub options: HasMany<EventResponseOption, rel_events_response_options::event_id>,
}

[weiznich]

Hmm, that is interesting, as the corresponding test cases for order clauses seems to work. Can you put together a small example that reproduces the issue?

[andrejohansson]

Don´t know about small, but here is the project. I sent you the password in private.

Nevermind, no pm function found on github. Must be getting tired here. 😄
Password is: myweddingpage

[weiznich]

I think I've found the problem. Order is taking a list of order expressions, so you need to pass an array there. I've no data to test, but the following graphql request generates the expected sql:

{
  Events(order: [{column: id, direction: ASC}]) {
    id
    name
    start_time
  }
}

That said, I still consider this to be a bug, because a invalid request should generate an error and not silently drop something.

[andrejohansson]

Thank you!

I can confirm that using an array works for me.