pradeepgokul-patch #1063
Closed
pradeepgokul-patch #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited cards.js
- 22:9 error Unexpected var, use let or const instead no-var - 24:9 error Unexpected console statement no-console - 24:21 error Unexpected string concatenation prefer-template - 24:21 error Strings must use singlequote quotes - 62:7 error 'CardEstimate' is defined but never used no-unused-vars - tried fixing this but not sure what the error is. - 87:4 error Missing trailing comma comma-dangle - 88:2 error Newline required at end of file but not found eol-last
Edited cards.js
- 22:9 error Unexpected var, use let or const instead no-var - 24:9 error Unexpected console statement no-console - 24:21 error Unexpected string concatenation prefer-template - 24:21 error Strings must use singlequote quotes - 62:7 error 'CardEstimate' is defined but never used no-unused-vars - tried fixing this but not sure what the error is. - 87:4 error Missing trailing comma comma-dangle - 88:2 error Newline required at end of file but not found eol-last
* zero was being accepted but not displayed, * float point numbers weren't accepted * the size of the fields were all strange, now they've been fixed and aligned properly
Feature: Hourly Estimate for Cards
* also filtered out hidden boards on `BoardsList.jade`
* subBoardId and subBoardSlug need to be stored, * new `mutations` needed as well
Sub-Board Preliminary Delivery
* fixes issue where Board List doesn't show any boards on startup
SubBoard bugfixes
Credit to https://css-tricks.com/css3-progress-bars/ for design
Update 'devel' to `v0.12 2017-03-05 Wekan` release
ProgressBar Delivery
|
|
|
Please close this pull request and create new one with these changes already there:
|
|
I did start fix all those myself but I got lost with all the errors. |
ghost
reviewed
Jun 18, 2017
| @@ -7,6 +7,9 @@ head | |||
| difficult to do that cleanly with Blaze -- at least without adding extra | |||
| packages. | |||
| link(rel="shortcut icon" href="/wekan-favicon.png") | |||
| script(src="https://use.typekit.net/sye2guq.js") | |||
There was a problem hiding this comment.
Should reference an internal file (same origin as wekan server) instead of an external file in order to:
- protection of private life
- security issues
- instability due to an external update of the file
- possibility to use wekan in a closed network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is