i-numbers can have a dotted suffix #2530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
See wellcomecollection/wellcomecollection.org#10565
There are some iconographic numbers (e.g.
3329263i.104
on vu3mwczx) which have a numeric suffix after a dot. These are currently being erroneously ignored by the validation that expects a number followed byi
.This fixes that bug.
How to test
This is pretty well isolated, so the unit tests should cover it quite well. When this has been deployed and the relevant records indexed, then records like vu3mwczx should show a
Reference
beneath the title (Reference: 3329263i.104
in this case), in the same way as https://wellcomecollection.org/works/g8j7y2xhHave we considered potential risks?
It is syntactically possible that a Sierra record might have multiple valid
001
fields. If a dotted one appears ahead of an undotted one, then the reference displayed for that record will change.