Remove cache control headers #9832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
jamieparkinson
suggested changes
May 23, 2023
There was a problem hiding this comment.
Difficult one with the default value! I had said that we shouldn't set a max-age but that doesn't tell us what we should set... I see why you went with public, but on the other hand MDN tells us that:
If a request doesn't have an
Authorizationheader, or you are already usings-maxageormust-revalidatein the response, then you don't need to usepublic.
which makes our intentions confusing when reading the code. My suggestion is in 2 parts:
- We should do this regardless: encapsulate the logic of what we want to do with the cache headers, so it doesn't have to be duplicated in each
getServerSideProps- this also means we can document it better.
That probably looks like a functionsetCacheControl(res: ServerResponse): voidthat lives somewhere incommonand can just be called in eachgetServerSidePropslikesetCacheControl(context.res). - Then thinking about what to do in that function... I was thinking we'd have to choose a
max-age, but your PR title gave me another idea! How about we just dores.removeHeader('Cache-Control')- no decisions about defaults necessary! When you do this, let's add a comment explaining our reasoning (ie the fact that Next sets defaults and the fact that caching is handled in CloudFront), and let's link to the CloudFront docs and our existing cache policies
The one caveat with my suggestion (2) is if Next.js adds the header back in - we'll need to check to see whether it does that, and if it does I think, on balance, and reading the CloudFront docs, we should add a max-age of an hour in rather than relying on default behaviours from not setting it. (I know I've changed my mind on that, sorry!)
jamieparkinson
approved these changes
May 24, 2023
Co-authored-by: Jamie Parkinson <j.parkinson@wellcome.ac.uk>
AMBacelar
force-pushed
the
remove-cache-control-headers
branch
from
7fd0d2d to
1519715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this for?
Platform, by making this change to the cache-control headers, we allow users to access cached resources, instead of forcing the platform to constantly repeat the same request multiple times and taking the service down
What is it doing for them?
for now, removing all the no-cache responses, to be fine tuned at a later time, Amazon Cloudfront does have it's own cache control settings, so we will need to see what the behaviour ends up being.
note: as stated here you cannot set Cache-Control headers in the next.config file so I had to set it in all the pages files individually.