Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md - added to sites using tabi #257

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Update README.md - added to sites using tabi #257

merged 2 commits into from
Jan 21, 2024

Conversation

andwati
Copy link
Contributor

@andwati andwati commented Jan 20, 2024

Added to sites using tabi

Summary

Related issue

Changes

Accessibility

Screenshots

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@andwati andwati requested a review from welpo as a code owner January 20, 2024 20:05
@welpo
Copy link
Owner

welpo commented Jan 20, 2024

Hi!

Can you add a newline between your new row and the "Using tabi?" text? Otherwise it won't render properly.

Thanks!

@andwati
Copy link
Contributor Author

andwati commented Jan 21, 2024 •
edited
Loading

Hi!

Can you add a newline between your new row and the "Using tabi?" text? Otherwise it won't render properly.

Thanks!

okay done

@welpo
Copy link
Owner

welpo commented Jan 21, 2024

Thanks!

@welpo welpo merged commit 24bb8d0 into welpo:main Jan 21, 2024
Smtbook pushed a commit to Smtbook/zola-theme-tabi that referenced this pull request Feb 29, 2024
@andwati @Smtbook
📝 chore(README): add andwati.github.io to showcase (welpo#257)
e8bd23a
welpo added a commit that referenced this pull request Sep 15, 2024
@welpo
🌐 style(RTL): improve RTL styling consistency
cd32625 
- Replace directional properties with logical ones.
- Enhance compatibility with right-to-left languages across the site's design.

Related: #257 #262 #270 #272 #274 #368
@welpo welpo mentioned this pull request Sep 15, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welpo welpo Awaiting requested review from welpo welpo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andwati @welpo