Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add summary for Recur #3

Merged
merged 1 commit into from
Aug 15, 2020
Merged

add summary for Recur #3

merged 1 commit into from
Aug 15, 2020

Conversation

stc04003
Copy link
Collaborator

Things to note: 1. I didn't include any documentation. 2. I used event = 0 to determine terminal times.

@wenjie2wang wenjie2wang merged commit 03da4fa into wenjie2wang:master Aug 15, 2020
@wenjie2wang
Copy link
Owner

@stc04003 Thanks for PR.

I have merged it to the master branch with some function documentation and tweaks: 34f6d19. Could you have a quick look to see if I understand them correctly?

I also added you as one of the contributors to the package. I would be glad to add you as one of the authors later if you contribute more. For minor updates, I think you may directly do it without PR. For major changes, a PR and review process would still be preferred. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants