Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Change the Differ's bottom section's height by just dragging up or down #1707

Open
1 task
NastyFlytrap opened this issue May 24, 2024 · 3 comments
Open
1 task

Comments

@NastyFlytrap
Copy link

What feature would you like to see?

The diffing tab has a bottom section that lists the changed bits. I want to make that less tall, and preferably be able to adjust it on the fly by just grabbing the edge and pulling up or down.

How will this feature be useful to you and others?

It'd make the application more customizable.

Request Type

  • I can provide a PoC for this feature or am willing to work on it myself and submit a PR

Additional context?

No response

@sisco0
Copy link

sisco0 commented Jun 9, 2024

Source code section of interest is found at diffing plugin, specifically at the view_diff.cpp file.

I could observe that we have ImGuiTableFlags_Resizable flag active.
However, @WerWolv, should we have some kind of Split for the current behavior to work as expected? (Resizable).

Might be somehing like the following before going on the differences table should do the trick?

    // Add the splitter to adjust the height of the bottom section
    ImGui::Splitter(true, 4.0f, &bottom_height, nullptr, 100.0f, 100.0f, height);

@WerWolv
Copy link
Owner

WerWolv commented Jun 9, 2024

I'm not sure an API like that exists but I have some similar code in the pattern editor view already where the console window is resizable. Maybe the same could be done in the diff view too

@sisco0
Copy link

sisco0 commented Jun 9, 2024

Thank you for this tip @WerWolv.

Considering the given answer, it would be compliant that a modification over the view_diff.cpp file be performed that contains a similar content such as the one referred to the dragging variable at view_pattern_editor.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants