Feat/duplicate page #191
Merged
Feat/duplicate page #191
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add duplicate-page button to page pulldown menu.
* Add duplicate-page modal. * Fix tag id "newPageName" for duplicate-page to "duplicatePageName" (because it was same id with move-page's "newPageName"). * Implement page-duplicate api.
* Change duplicate icon fa-clone. * Fix translation label.
yuki-takei
reviewed
Oct 13, 2017
lib/routes/page.js
Outdated
| return res.json(ApiResponse.error(err)); | ||
| });; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
ちょっと適当な提案するけど、このメソッド、他の create とかのラッパーとして実装する事ってできないかな？新しくページ作る部分はコード重複してるしやってること同じだと思うんだよね。
There was a problem hiding this comment.
そもそもとして、 models/page.js に、複製を実行するメソッドの実装は不要でした。
create の引数を変えるだけでよいことが判明したので、
api.duplicate から呼び出すメソッドを create に変更して対応するように修正しています。
* Delete page-duplicate execute function. * Change call function duplicate -> create in page-duplication-api. * Fix options for call page-create function from page-duplication-api.
* Change api.duplicate's calling function Page.create to api.create. (Api.duplicate wraps api.create, not call direct Page.create.)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of page duplication function.
ページ複製機能の実装