-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mark to check for the presence of drafts #8681
feat: Mark to check for the presence of drafts #8681
Conversation
@@ -113,6 +116,7 @@ export const PageEditorModeManager = (props: Props): JSX.Element => { | |||
onClick={editButtonClickedHandler} | |||
> | |||
<span className="material-symbols-outlined me-1 fs-5">edit_square</span>{t('Edit')} | |||
{ hasYjsDraft && <span className="position-absolute top-0 start-100 translate-middle p-1 bg-primary border border-light rounded-circle" />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-light だけ、このままでいいのかどうか再考してほしい
light/dark mode 対応したほうがいいのか、外すだけで問題ないのか
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-light を外しました (ふみやさんと合意済み)
@@ -113,6 +116,7 @@ export const PageEditorModeManager = (props: Props): JSX.Element => { | |||
onClick={editButtonClickedHandler} | |||
> | |||
<span className="material-symbols-outlined me-1 fs-5">edit_square</span>{t('Edit')} | |||
{ hasYjsDraft && <span className="position-absolute top-0 start-100 translate-middle p-1 bg-primary border border-light rounded-circle" />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-light だけ、このままでいいのかどうか再考してほしい
light/dark mode 対応したほうがいいのか、外すだけで問題ないのか
@@ -68,6 +68,9 @@ export const PageEditorModeManager = (props: Props): JSX.Element => { | |||
|
|||
const { isCreating, createAndTransit } = useCreatePageAndTransit(); | |||
|
|||
// TODO: https://redmine.weseek.co.jp/issues/132775 | |||
const hasYjsDraft = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
名前これでいいのかな…
ストーリーに
View を見ているのかエディタを開いているのかという情報を含む
という条件を考慮するようには書いてあるので、後続タスクで変数名で何が相応しいのかは改めて考えてほしい
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Task
#132775 [v7][New Editor][collab] Editor で編集中またはドラフトが存在することを subnav から確認できる
┗ #141357 デザイン実装
XD
Screenshot