feat: Mark to check for the presence of drafts #8681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
commented
Apr 4, 2024
| @@ -113,6 +116,7 @@ export const PageEditorModeManager = (props: Props): JSX.Element => { | |||
| onClick={editButtonClickedHandler} | |||
| > | |||
| <span className="material-symbols-outlined me-1 fs-5">edit_square</span>{t('Edit')} | |||
| { hasYjsDraft && <span className="position-absolute top-0 start-100 translate-middle p-1 bg-primary border border-light rounded-circle" />} | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
border-light だけ、このままでいいのかどうか再考してほしい
light/dark mode 対応したほうがいいのか、外すだけで問題ないのか
There was a problem hiding this comment.
border-light を外しました (ふみやさんと合意済み)
yuki-takei
requested changes
Apr 4, 2024
| @@ -113,6 +116,7 @@ export const PageEditorModeManager = (props: Props): JSX.Element => { | |||
| onClick={editButtonClickedHandler} | |||
| > | |||
| <span className="material-symbols-outlined me-1 fs-5">edit_square</span>{t('Edit')} | |||
| { hasYjsDraft && <span className="position-absolute top-0 start-100 translate-middle p-1 bg-primary border border-light rounded-circle" />} | |||
There was a problem hiding this comment.
border-light だけ、このままでいいのかどうか再考してほしい
light/dark mode 対応したほうがいいのか、外すだけで問題ないのか
yuki-takei
reviewed
Apr 4, 2024
| @@ -68,6 +68,9 @@ export const PageEditorModeManager = (props: Props): JSX.Element => { | |||
|
|
|||
| const { isCreating, createAndTransit } = useCreatePageAndTransit(); | |||
|
|
|||
| // TODO: https://redmine.weseek.co.jp/issues/132775 | |||
| const hasYjsDraft = false; | |||
There was a problem hiding this comment.
名前これでいいのかな…
ストーリーに
View を見ているのかエディタを開いているのかという情報を含む
という条件を考慮するようには書いてあるので、後続タスクで変数名で何が相応しいのかは改めて考えてほしい
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
#132775 [v7][New Editor][collab] Editor で編集中またはドラフトが存在することを subnav から確認できる
┗ #141357 デザイン実装
XD
Screenshot