Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatically repair corrupted data, at least for the latest revision #9002

Merged
merged 16 commits into from
Jul 31, 2024

Conversation

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 62d56e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


if (await Revision.exists({ pageId: { $eq: pageId } })) {
return;
}
Copy link
Member

@miya miya Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9001 が適用されていない環境で 20211227060705-revision-path-to-page-id-schema-migration--fixed-7549.js が実行されることによって大半の revision.pageId が特定の pageId に書き換わってしまうという症状があった。

書き換わってしまった pageId を持つ page で History modal を開くことによって本来持っていなかった revision (閲覧制限がかかっていたページも含む) の中身を閲覧することができてしまう可能性がありそうです。

Copy link

reg-suit bot commented Jul 31, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit c82658e into master Jul 31, 2024
24 of 25 checks passed
@yuki-takei yuki-takei deleted the fix/broken-revisions-collection branch July 31, 2024 09:07
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants