-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatically repair corrupted data, at least for the latest revision #9002
Conversation
|
apps/app/src/server/service/revision/normalize-latest-revision-if-broken.ts
Fixed
Show fixed
Hide fixed
apps/app/src/server/service/revision/normalize-latest-revision-if-broken.ts
Fixed
Show fixed
Hide fixed
|
||
if (await Revision.exists({ pageId: { $eq: pageId } })) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9001 が適用されていない環境で 20211227060705-revision-path-to-page-id-schema-migration--fixed-7549.js
が実行されることによって大半の revision.pageId が特定の pageId に書き換わってしまうという症状があった。
書き換わってしまった pageId を持つ page で History modal を開くことによって本来持っていなかった revision (閲覧制限がかかっていたページも含む) の中身を閲覧することができてしまう可能性がありそうです。
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Tasks