feat(types): adds some types #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types are for me, not you.
boneskull
force-pushed
the
boneskull/how-about-some-types
branch
from
d86549d to
ee98a59
Compare
wesleytodd
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
I would love some tests for these, but for sure not blocking this on that. I can set those up later just fine.
EDIT: Oh just seeing this one! #17 Disregard the previous comment
| @@ -0,0 +1,91 @@ | |||
|
|
|||
| declare module 'loggerr' { | |||
| type Formatter = 'browser' | 'bunyan' | 'cli' | 'default'; | |||
There was a problem hiding this comment.
I recently added a new cli-simple https://github.com/wesleytodd/loggerr/blob/main/formatters/cli-simple.js
|
Closing in favor of #17 which contains this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types are for me, not you.