Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chat doesn't work during [delay] #1856

Closed
gfgtdf opened this issue Jul 23, 2017 · 5 comments
Closed

chat doesn't work during [delay] #1856

gfgtdf opened this issue Jul 23, 2017 · 5 comments
Assignees
Labels
Bug Issues involving unexpected behavior. MP Issues with multiplayer support or bundled multiplayer content. UI User interface issues, including both back-end and front-end issues.
Milestone

Comments

@gfgtdf
Copy link
Contributor

gfgtdf commented Jul 23, 2017

as said in the title, during a [delay] the players should be able to send & receive chat messages but they can't

@gfgtdf gfgtdf added Bug Issues involving unexpected behavior. MP Issues with multiplayer support or bundled multiplayer content. UI User interface issues, including both back-end and front-end issues. labels Jul 23, 2017
@CelticMinstrel
Copy link
Member

Does delay use something like SDL_Delay? The proper implementation would be to lock out player controls and just run a game loop until the delay is expired... there's a function called somewhere from the AI that should have that effect.

@gfgtdf
Copy link
Contributor Author

gfgtdf commented Jul 23, 2017

delay doesn't freeze the game, you can still open the chatbox, you also see the chat that you just entered at the left-upper corner of the window. It just that you don't receive chat form other and/or the chatmessages are not immidiatley send to others.

@CelticMinstrel
Copy link
Member

Ah, so it probably is implemented (mostly?) correctly then.

@gfgtdf
Copy link
Contributor Author

gfgtdf commented Nov 4, 2017

yes the only problem is that the chat isn't sended (or received by, not sure here) to other players until after the [delay] (or probably the whole user action?) has finished. I perosnally think this is still an important issue.

The problem with trying to read chat from the network during [delay] is that one might find other user commands, (recruit/recall etc.) that cannpt be processed during a delay and the network thing (playturn_network_adapter.cpp) doesn't have a 'push_front()' function to push those unhandled netorkpackages back for later.

@gfgtdf gfgtdf self-assigned this Nov 4, 2017
@gfgtdf
Copy link
Contributor Author

gfgtdf commented Mar 24, 2018

it'd be nice if this could go into 1.14 or 1.14.1 . No gurantee though: since i dont know yet how involved such a fix would be i cannot say right now whether it'd be good for 1.14

@gfgtdf gfgtdf added this to the 1.14.1 milestone Mar 24, 2018
gfgtdf added a commit to gfgtdf/wesnoth that referenced this issue Mar 25, 2018
gfgtdf added a commit that referenced this issue Mar 25, 2018
@gfgtdf gfgtdf modified the milestones: 1.14.1, 1.14.0 Apr 6, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 6, 2018
jostephd pushed a commit to jostephd/wesnoth that referenced this issue Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues involving unexpected behavior. MP Issues with multiplayer support or bundled multiplayer content. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

No branches or pull requests

2 participants