-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chat doesn't work during [delay] #1856
Comments
Does delay use something like |
delay doesn't freeze the game, you can still open the chatbox, you also see the chat that you just entered at the left-upper corner of the window. It just that you don't receive chat form other and/or the chatmessages are not immidiatley send to others. |
Ah, so it probably is implemented (mostly?) correctly then. |
yes the only problem is that the chat isn't sended (or received by, not sure here) to other players until after the [delay] (or probably the whole user action?) has finished. I perosnally think this is still an important issue. The problem with trying to read chat from the network during [delay] is that one might find other user commands, (recruit/recall etc.) that cannpt be processed during a delay and the network thing (playturn_network_adapter.cpp) doesn't have a 'push_front()' function to push those unhandled netorkpackages back for later. |
it'd be nice if this could go into 1.14 or 1.14.1 . No gurantee though: since i dont know yet how involved such a fix would be i cannot say right now whether it'd be good for 1.14 |
fixes wesnoth#1856 (cherry-picked from commit 274da80)
as said in the title, during a [delay] the players should be able to send & receive chat messages but they can't
The text was updated successfully, but these errors were encountered: