Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Cutscene Themes #2115

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Conversation

sigurdfdragon
Copy link
Contributor

Makes use of Cutscene and Cutscene_Minimal themes for all scenarios in mainline that I am aware would benefit from it.

There seems to be a slight graphical hiccup when switching to Cutscene mid scenario in the third commit.

@CelticMinstrel
Copy link
Member

With the second commit, if the user selects a different theme in preferences (for example, Classic), will that choice be honoured after the cutscene has ended.

If not, I'd suggest trying theme= - an empty attribute.

@sigurdfdragon
Copy link
Contributor Author

sigurdfdragon commented Oct 24, 2017

@CelticMinstrel No, it wasn't honored. Thanks for the suggestion, that worked, and I've updated the commit. (and the wiki)

@sigurdfdragon
Copy link
Contributor Author

sigurdfdragon commented Oct 24, 2017

I think I may remove part of the 2nd commit and all of the 3rd.
The third one because of the glitch, and both because for the non-SotA changes I'm not sure the cases warrant using them, and that's a decision best left for the campaign maintainers.

@Vultraz
Copy link
Member

Vultraz commented Oct 25, 2017

I think we should just merge the first commit for now.

@CelticMinstrel
Copy link
Member

You can totally cherry-pick it and leave the PR open, if you want.

@sigurdfdragon
Copy link
Contributor Author

I'll strip it down to the first commit and get it merged by the end of the week.
I'll pick the other two and stash them on a local branch of my repo copy.

Used for scenarios that are dialog only and use [endlevel] linger=no.
Two scenarios in NR had linger=no added for Cutscene_Minimal use.
@Vultraz Vultraz merged commit ca853a0 into wesnoth:master Oct 27, 2017
@sigurdfdragon sigurdfdragon deleted the Deploy_Cutscene branch May 28, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants