Refactored display-class theme initialization #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* controller_base::get_theme was removed and replaced with theme::get_theme_config. There was already a static map of theme configs in the theme class, so no need to reinvent the wheel. * Renamed theme::get_known_themes to theme::get_basic_theme_info * Hidden themes will be included in the known_themes map. Filtering now happens in get_basic_theme_info, which now has an additional `include_hidden` (false by default) argument. * display::set_theme now takes the theme id instead of config * editor_display no longer takes a theme_config/id argument and instead simply initializes its base class with the "editor" theme directly. * display now takes the theme id instead of config. game_display was adjusted accordingly
github-actions
bot
added
Editor
stevecotton
reviewed
Mar 31, 2022
|
|
||
| static const config& get_theme_config(const std::string& id); | ||
|
|
||
| static std::vector<theme_info> get_basic_theme_info(bool include_hidden = false); |
There was a problem hiding this comment.
Please add some documentation, clarify that it's "basic info" rather than "info about the basic theme".
There was a problem hiding this comment.
Will add in separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of theme configs in the theme class, so no need to reinvent the wheel.
has an additional
include_hidden(false by default) argument."editor" theme directly.