Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored display-class theme initialization #6601

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Commits on Mar 31, 2022

  1. Refactored display-class theme initialization

    * controller_base::get_theme was removed and replaced with theme::get_theme_config. There was already a static map
      of theme configs in the theme class, so no need to reinvent the wheel.
    * Renamed theme::get_known_themes to theme::get_basic_theme_info
    * Hidden themes will be included in the known_themes map. Filtering now happens in get_basic_theme_info, which now
      has an additional `include_hidden` (false by default) argument.
    * display::set_theme now takes the theme id instead of config
    * editor_display no longer takes a theme_config/id argument and instead simply initializes its base class with the
      "editor" theme directly.
    * display now takes the theme id instead of config. game_display was adjusted accordingly
    Vultraz committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    dfc1967 View commit details
    Browse the repository at this point in the history